Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nix-env evaluation #92

Merged
merged 1 commit into from Jan 9, 2019
Merged

fix nix-env evaluation #92

merged 1 commit into from Jan 9, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 4, 2019

nix-env picked up default.nix, which contained our hardware profiles.
This is not only cpu-intensive to evaluate but also fails because
it does some import-from-derivation.
By moving default.nix to release.nix it should be no longer loaded

nix-env picked up `default.nix`, which contained our hardware profiles.
This is not only cpu-intensive to evaluate but also fails because
it does some import-from-derivation.
By moving default.nix to release.nix it should be no longer loaded
@Mic92
Copy link
Member Author

Mic92 commented Jan 4, 2019

fixes #90

@kalbasit
Copy link
Member

kalbasit commented Jan 9, 2019

would this break configurations loading the nixos hardware with import <nixos-hardware>? in other words, do I have to explicitly specify release.nix?

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukateras
Copy link
Member

would this break configurations loading the nixos hardware with import ? in other words, do I have to explicitly specify release.nix?

I don't think so; this has never been supported API.

@Mic92 Mic92 merged commit f0db394 into master Jan 9, 2019
@Mic92 Mic92 deleted the fix-nix-env branch January 9, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants