Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems found on Linux #2055

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Fix problems found on Linux #2055

merged 2 commits into from
Jan 4, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jan 4, 2019

No description provided.

Makefile Show resolved Hide resolved
# NOTE(egg): this assumes that only the plugin-dependent tests need to be linked
# against mock objects. The classes further up that are big enough to be mocked
# are likely to be highly templatized, so this will probably hold for a while.
# library instead of statically linking the objects.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the note still holds, keep it.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jan 4, 2019
@pleroy pleroy merged commit afba64d into mockingbirdnest:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants