New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/xss-lock: specify a default locker #53404
Conversation
test is still building. |
Test works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I was unsure what a sensitive default is in this case when I wrote this module as I don't know enough about X internals and how locking works (and if there are differences between desktop environments).
The implementation seems fine though, so if this is a sensitive default I'm totally 👍 for merging.
I support the idea of setting a default screen locker. But i'm not sure
|
@xeji what the is the compromise between UX and closure-size? The fancy one could go to the example section. |
I would recommend non-fancy |
Having a default locker is less error-prone and more convenient. Incorrect values might leave the machine vulnerable since there is no fallback.
In case someone is interested. I also added the dim-screen script as described in the manpage, which will dim the screen before locking it: https://github.com/Mic92/dotfiles/blob/bb297e471a52c3feba6756c857c72db6bbc5d208/nixos/vms/modules/xss-lock.nix#L14 |
Having a default locker is less error-prone and more convenient.
Incorrect values might leave the machine vulnerable since there is no
fallback.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)