Remove line that caused tests to not indent at all in the tests and fix regression #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etu
changed the title
|
So got a test failure on the first commit, which was the point. And that failure should be fixed with the second commit. |
etu
changed the title
… indents at all This is to prevent bugs with running the indentation code at all in the future to not have regressions related to that.
matthewbauer
reviewed
Jan 4, 2019
| @@ -117,7 +117,7 @@ Valid functions for this are: | |||
|
|
|||
| (defconst nix-re-quotes "''\\|\"") | |||
|
|
|||
| (defconst nix-re-comments "#\\|/\\*\\|\\*/") | |||
| (defconst nix-re-comments "#\\|/*\\|*/") | |||
There was a problem hiding this comment.
Hm... Perhaps I don't know emacs regex as well as I thought. But shouldn't the * be escaped here? You want it to match /* and */.
There was a problem hiding this comment.
Well, my elisp regex is bad as well. I just evalled the older revision of the file and grabbed the value from there. So the one I changed it to here is the one that been in use for ages.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #64.
Still work in progress. Just wanted to see the test failure from travis.