Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_12: init at go 1.12 #56500

Merged
merged 2 commits into from Mar 4, 2019
Merged

go_1_12: init at go 1.12 #56500

merged 2 commits into from Mar 4, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 28, 2019 •
edited

Motivation for this change

The build cache is now required as a step toward eliminating $GOPATH/pkg. Setting the environment variable GOCACHE=off will cause go commands that write to the cache to fail. I've updated all the packages that I could find and are using go without using buildGoPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS (sandbox off)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested with

λ nix run -f '<nixpkgs>' nur.repos.kalbasit.nix-verify -c nix-verify -I nixpkgs=`pwd` \
        -A bazel-watcher \
        -A boringssl \
        -A cadvisor \
        -A cide \
        -A cni-plugins \
        -A deepin.dbus-factory \
        -A deepin.dde-api \
        -A deepin.dde-daemon \
        -A deepin.deepin-desktop-base \
        -A deepin.deepin-desktop-schemas \
        -A deepin.deepin-metacity \
        -A deepin.deepin-wallpapers \
        -A deepin.deepin-wm \
        -A deepin.go-dbus-generator \
        -A deepin.go-gir-generator \
        -A docker \
        -A docker-gc \
        -A gitlab-shell \
        -A gitlab-workhorse \
        -A go \
        -A go_1_11 \
        -A gometalinter \
        -A kubectl \
        -A kubectx \
        -A kubernetes \
        -A pipework \
        -A prometheus \
        -A prometheus-alertmanager \
        -A prometheus-pushgateway \
        -A prometheus_2 \
        -A python37Packages.jupyter-repo2docker \
        -A rkt \
        -A singularity \
        -A tmsu \
        -A vault \
        -A vgo2nix \
        -A vimPlugins.vim-go

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build bazel-watcher boringssl cadvisor cide cni-plugins deepin.dbus-factory deepin.dde-api deepin.dde-daemon deepin.deepin-desktop-base deepin.deepin-desktop-schemas deepin.deepin-metacity deepin.deepin-wallpapers deepin.deepin-wm deepin.go-dbus-generator deepin.go-gir-generator docker docker-gc gitlab-shell gitlab-workhorse go go_1_11 gometalinter kubectl kubectx kubernetes pipework prometheus prometheus-alertmanager prometheus-pushgateway prometheus_2 python37Packages.jupyter-repo2docker rkt singularity vault vgo2nix vimPlugins.vim-go

@kalbasit kalbasit force-pushed the nixpkgs_add-support-go-1-12 branch from c6bcc3b to 91479b6 Compare March 2, 2019 21:57
@kalbasit kalbasit marked this pull request as ready for review March 2, 2019 21:58
@kalbasit kalbasit force-pushed the nixpkgs_add-support-go-1-12 branch from 91479b6 to 6ef04ca Compare March 2, 2019 22:24
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2019 •
edited

The checksum error on darwin should be fixed though:

@GrahamcOfBorg build go_1_12

I suspect it might be a related to case-insenstive filesystem again.

@kalbasit
Copy link
Member Author

kalbasit commented Mar 3, 2019

@Mic92 I suspect that it is, as well. I tested the entire PR on Darwin myself, but unlike ofborg I’m running APPFS.

@kalbasit
go_1_12: switch to fetchurl for sha256 consistency on Darwin
252376c 
fetchFromGitHub and thus fetchzip hashes the contents of the archive and
not the archive itself. Unicode file names lead to different checksums
on HFS+ vs. other file systems because of Unicode normalisation
@kalbasit kalbasit force-pushed the nixpkgs_add-support-go-1-12 branch from 6fed306 to 252376c Compare March 4, 2019 00:33
@Mic92
Copy link
Member

Mic92 commented Mar 4, 2019

@GrahamcOfBorg build go_1_12

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2019 •
edited

This was the only package that failed to build on my machine.
Let's say what ofborg produces:

@GrahamcOfBorg build prometheus

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2019

The last darwin build error just look like resource depletion. I think we can ignore this given that you already build on macOS.

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2019

This was the build error log of prometheus: https://dl.thalheim.io/RRa5YdOzO7l0jKJ1cV01aA/prometheus.log

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2019

Ok. Maybe this was caused by my zfs filesystem or some other random stuff.

@Mic92 Mic92 merged commit 27cb066 into NixOS:master Mar 4, 2019
@kalbasit kalbasit deleted the nixpkgs_add-support-go-1-12 branch March 4, 2019 14:52
This was referenced Mar 4, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dtzWill dtzWill dtzWill left review comments

@cstrahan cstrahan Awaiting requested review from cstrahan

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: golang 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kalbasit @Mic92 @dtzWill @dicarlo2 @GrahamcOfBorg