Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrtool: init at 0.15 #56402

Merged
merged 1 commit into from May 14, 2019
Merged

ctrtool: init at 0.15 #56402

merged 1 commit into from May 14, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

A tool I use for 3ds modding

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Mar 25, 2019
View reviewed changes
pkgs/tools/archivers/ctrtool/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@marius851000 marius851000 force-pushed the ctrtool branch 2 times, most recently from 4fa03fa to 64f4a5a Compare March 26, 2019 10:52
aanderse
aanderse approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aanderse
aanderse approved these changes Apr 6, 2019
View reviewed changes
pkgs/tools/archivers/ctrtool/default.nix Outdated Show resolved Hide resolved
@marius851000
Copy link
Contributor Author

@aanderse It's ready for merge

aanderse
aanderse requested changes May 10, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some things I missed reviewing last time around. Please let me know if you have any questions.

pkgs/tools/archivers/ctrtool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/archivers/ctrtool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/archivers/ctrtool/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@marius851000 given your comment about not receiving notification in the other PR I thought I'd ping you here to be sure.

@marius851000
Copy link
Contributor Author

@aanderse that's done.

@aanderse
Copy link
Member

@GrahamcOfBorg build ctrtool

@aanderse aanderse merged commit 751c91c into NixOS:master May 14, 2019
@aanderse
Copy link
Member

@marius851000 thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marius851000 @aanderse @joachifm @GrahamcOfBorg