Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer/header of servers.openttd.org #63

Closed
planetmaker opened this issue Feb 25, 2019 · 6 comments
Closed

footer/header of servers.openttd.org #63

planetmaker opened this issue Feb 25, 2019 · 6 comments

Comments

@planetmaker
Copy link
Contributor

The server listing is missing header, menu and footer.
https://servers.openttd.org/en/

@auge8472
Copy link
Contributor

I also saw that the server listing page misses the mentioned elements. As far I can see, the server listing is not really part of the sources.

@glx22
Copy link
Contributor

glx22 commented Feb 25, 2019

It's still on the old infra IIRC

@TrueBrain
Copy link
Member

Not sure you are seeing what I am seeing. It has a header. It has a footer.

image
That does look like a header to me?

It does not have a menu, but that is on purpose. There is nothing to menu, basically :) I could add a single entry, like on http://security.openttd.org/en, but not sure that really makes a difference.

But yeah, this site still lives on the old infrastructure. As such, I am not really moved to change it. Unless there really is a bug, like really a missing header/footer. But I see the header/footer just fine, just like on any other subdomain of ours (like https://bananas.openttd.org/en). Am I missing something?

@TrueBrain
Copy link
Member

TrueBrain commented Feb 25, 2019

Right, after talking on IRC, the issue really was lacking a description:

  • because 'servers' is on a different subdomain, the header/menu changes. This is the only link in our www menu that points to a site similar looking, and as such it jumps out more. The fact that Community also lacks the menu is therefor less of an issue. Not sure what can be done about this.
  • There is no menu on this page. We could add a single entry, like on security. fixed now
  • The footer on all old-infrastructure (bananas, security, servers, ..) looks weird, because it has an empty box (used to be where we showed the banners). This could be removed completely. fixed now
  • The logo points to a weird address. This is fixable. fixed now

@TrueBrain
Copy link
Member

Fixed 3 out of the 4 issues mentioned above. The last one is not easy to fix; at least, I don't really have ideas. Also not sure it is worth any time, as that part of the website should be replaced anyway.

Going to close this for now. If you find more issues, please open a new bug (and please, be more descriptive :D). Tnx!

@auge8472
Copy link
Contributor

A real™️ solution for the missed menu would be a complete menu and not only the single menu point that points to itself. I want to jump to differnet pages with the help of the menu and with no or the current single point menu I can't.

I expect the menu on the server listing page to be something like a handmade menu without an automatism for inclusion of new menu points. That's a drawback because someone has to remember the need of an adaption of the server listing menu.

I've no idea how to solve this problem but wanted to share my thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants