Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.tp_smapi: fix evaluation #56456

Merged
merged 1 commit into from Feb 27, 2019
Merged

linuxPackages.tp_smapi: fix evaluation #56456

merged 1 commit into from Feb 27, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

has been broken by dadc7eb

This breaks the tarball build (https://hydra.nixos.org/build/89564380) and hence the unstable channel.

@grahamc Doesn't ofborg test building the tarball?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92 @Ericson2314

@dotlambda dotlambda added 9.needs: port to stable A PR needs a backport to the stable release. 1.severity: blocker labels Feb 27, 2019
@Mic92 Mic92 merged commit 53bbc20 into NixOS:master Feb 27, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 27, 2019

Thanks!

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2019

backport:

[detached HEAD 5c1a47c] linuxPackages.tp_smapi: fix evaluation
Author: Robert Schütz robert.schuetz@stud.uni-heidelberg.de
Date: Wed Feb 27 12:02:52 2019 +0100
1 file changed, 2 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: blocker 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @Mic92 @GrahamcOfBorg