Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: tensorflow: 1.11 -> 1.13 #56424

Closed
wants to merge 1 commit into from
Closed

python: tensorflow: 1.11 -> 1.13 #56424

wants to merge 1 commit into from

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Feb 26, 2019 •
edited

Motivation for this change

Best thing here is the dropped python3.7 restriction. Not sure about all the old-version cruft, it's not in use, but maybe it's being left in for easier overrides?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@averelld averelld requested a review from FRidh as a code owner February 26, 2019 18:45
@costrouc
Copy link
Member

@averelld to clarify this means that with this commit python37Packages.tensorflow will be available?

@averelld
Copy link
Contributor Author

Yes, exactly, "Support for Python3.7 on all operating systems." is new in TF 1.13.

@xiorcale xiorcale mentioned this pull request Feb 28, 2019
Closed
10 tasks
@averelld
Copy link
Contributor Author

averelld commented Mar 1, 2019

Closing in favor of #56515 which is more thorough.

@averelld averelld closed this Mar 1, 2019
@jyp
Copy link
Contributor

jyp commented Mar 1, 2019

The python 3.7 support isn't in #56515
Do you think that you could rebase your PR over it? @averelld

@averelld
Copy link
Contributor Author

averelld commented Mar 1, 2019

@jyp Sure, here: averelld/nixpkgs@0e06f4c but there's just the missing if and the new hashes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@averelld @costrouc @jyp @GrahamcOfBorg