ping: init 0.6.0 #56428
ping: init 0.6.0 #56428
Conversation
|
|
||
| src = fetchFromGitHub { | ||
| owner = "jeremyvaartjes"; | ||
| repo = "ping"; |
There was a problem hiding this comment.
| repo = "ping"; | |
| repo = pname; |
pkgs/top-level/all-packages.nix
Outdated
| @@ -9016,6 +9016,8 @@ in | |||
|
|
|||
| phantomjs2 = libsForQt5.callPackage ../development/tools/phantomjs2 { }; | |||
|
|
|||
| ping = callPackages ../development/web/ping { }; | |||
There was a problem hiding this comment.
| ping = callPackages ../development/web/ping { }; | |
| ping = callPackage ../development/web/ping { }; |
There was a problem hiding this comment.
Also I don't think this belongs in development/web.
This is a gui application that is useful for debugging web API's, so maybe applications/networking.
Note that our organization in nixpkgs is kinda questionable at times
There was a problem hiding this comment.
I put it in development/web because postman was there, which is more or less the same application than ping
Furthermore, it's a tool used for debugging API which are under development, so I think it makes sense to keep it here.
There was a problem hiding this comment.
Manual says that for things under development should be
it’s used to support software development
And then goes on to mention libraries, compilers, and build-managers.
None on which will ever become a gui application.
You could say that an application like this would support software development, but so could an IDE, and they never should go under development.
I'd say that things like postman should be moved to a new place under applications/ and the closest thing we have currently is something like applications/networking.
There was a problem hiding this comment.
I totally agree with you, I actually wanted to put the app under applications/networking before I discover that postman was under development/web
What should I do then ? Keeping consistency with the actual organization or move ping under applications/networking to better agree with the manual ?
There was a problem hiding this comment.
I'd say applications/networking would be the best place currently.
We usually clean up the actual organization eventually.
There was a problem hiding this comment.
Alright, I will move it to the right place then!
Also, I was wondering, wouldn't it be more convenient to have the curated apps from Elementary App Center organized under desktop/pantheon in a special directory for them? Because some of these apps seem to be tightly coupled with some part of the desktop (e.g. Wingpanel, ...).
There was a problem hiding this comment.
Alright, I will move it to the right place then!
Exclamation here confused me.
Also, I was wondering, wouldn't it be more convenient to have the curated apps from Elementary App Center organized under desktop/pantheon in a special directory for them? Because some of these apps seem to be tightly coupled with some part of the desktop (e.g. Wingpanel, ...).
I thought of this too, and I've decided that apps that specifically won't function without some part of the pantheon desktop can be organized there.
I've also patched granite so that they work outside pantheon (not needing wingpanel).
And even if they don't work I'd like them to default to not needing their desktop.
See: ac2546b
There was a problem hiding this comment.
Exclamation here confused me.
well, I was maybe a bit too enthusiastic that we found an agreement 😄
I had no idea about granite, but it makes sense yes. And the idea of the flag to default to not needing their desktop seems convenient too. Thanks for the details.
|
Can you also pull adding yourself to the maintainers-list into a separate commit? |
ping: init at 0.6.0 Update pkgs/development/web/ping/default.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update pkgs/development/web/ping/default.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update pkgs/development/web/ping/default.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update pkgs/development/web/ping/default.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update pkgs/development/web/ping/default.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update maintainers/maintainer-list.nix Co-Authored-By: Kjuvi <quentin.vaucher@protonmail.com> Update maintainer-list.nix ping: init at 0.6.0
fix missing glib Fix missing import: hicolor-icon-theme move ping under applications/networking ping: init at 0.6.0 ping: init at 0.6.0 maintainers: add kjuvi
|
Hope you found the review informative @Kjuvi , and thank you for your contribution ✨ |
Motivation for this change
Since Pantheon desktop has recently been added to Master, adding some "curated" apps from Elementary AppCenter seems to be a good idea to complete it.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)