Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kodiPlugins.osmc-skin: 17.0.4 -> 18.0.0 #56468

Merged
merged 1 commit into from Feb 27, 2019
Merged

kodiPlugins.osmc-skin: 17.0.4 -> 18.0.0 #56468

merged 1 commit into from Feb 27, 2019

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Feb 27, 2019 •
edited

Motivation for this change

With the recent v18 update merged, the nixpkgs' version of the OSMC skin plugin is no longer compatible. Since the "skin.osmc" repo doesn't do versioning, I just updated it to master's latest commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace previously requested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this commit osmc/skin.osmc@40a6c31 would be 18.0.0.

Also be sure to change version to that as well.

@worldofpeace
Copy link
Contributor

Forgot to mention that a commit msg that matches the contribution guidelines would be
kodiPlugins.osmc-skin: 17.0.4 -> 18.0.0

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@minijackson
Copy link
Member Author

I'd say this commit osmc/skin.osmc@40a6c31 would be 18.0.0

Good catch! Thank you

Sorry about commit title, I wasn't sure how that would apply to a plugin

@worldofpeace
Copy link
Contributor

Sorry about commit title, I wasn't sure how that would apply to a plugin

If you're ever unsure which attribute to use in the commit msg, the git history usually can reveal this pretty quick.

Just going to test that this builds now

@GrahamcOfBorg build kodiPlugins.osmc-skin

@worldofpeace worldofpeace dismissed their stale review February 27, 2019 18:14

resolved by author

@worldofpeace worldofpeace changed the title kodi: update osmc theme kodiPlugins.osmc-skin: 17.0.4 -> 18.0.0 Feb 27, 2019
worldofpeace
worldofpeace approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds fine 👍

@worldofpeace worldofpeace merged commit 6611269 into NixOS:master Feb 27, 2019
@worldofpeace
Copy link
Contributor

Thanks @minijackson ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @worldofpeace @GrahamcOfBorg