Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: experimental 0.16.51 -> 0.17.1 #56437

Merged
merged 1 commit into from Feb 27, 2019
Merged

factorio: experimental 0.16.51 -> 0.17.1 #56437

merged 1 commit into from Feb 27, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Feb 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@artemist
Copy link
Member

artemist commented Feb 27, 2019 •
edited

This seems to work, but note that 0.17.2 is out now

benley
benley approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work!

@benley benley merged commit f4bd833 into NixOS:master Feb 27, 2019
@benley
Copy link
Member

benley commented Feb 27, 2019

we might as well merge this and do 0.17.1 -> 0.17.2 in another PR

@artemist
Copy link
Member

0.17.2 is in #56488

@nyanloutre nyanloutre deleted the factorio-update branch March 16, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley benley approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @artemist @benley @GrahamcOfBorg