Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gipc,gdrivefs: update #56528

Merged
merged 2 commits into from
Mar 1, 2019
Merged

gipc,gdrivefs: update #56528

merged 2 commits into from
Mar 1, 2019
+4 −6

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 28, 2019 •
edited
Loading

Motivation for this change

Was working for moving to py3 for gdrivefs,
but that's only in latest git not a tagged release.

Even so, updates!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dtzWill dtzWill requested a review from FRidh as a code owner February 28, 2019 16:05
@dtzWill dtzWill merged commit 456ff62 into NixOS:master Mar 1, 2019
@dtzWill dtzWill deleted the update/gdrivefs-gipc-py3 branch March 1, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg