Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

davmail: 4.8.6 -> 5.2.0 #56532

Merged
merged 1 commit into from Mar 6, 2019
Merged

davmail: 4.8.6 -> 5.2.0 #56532

merged 1 commit into from Mar 6, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 28, 2019

Motivation for this change

5.2.0 announcement:

https://sourceforge.net/p/davmail/news/2019/02/davmail-520-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The UI appears when running davmail, but I haven't tried pointing at a
proper server or otherwise actually seeing it in action.

@dtzWill dtzWill requested review from dguibert and Mic92 March 4, 2019 06:18
@dtzWill
Copy link
Member Author

dtzWill commented Mar 4, 2019

(reviewers suggested by github, wasn't sure 😇)

dguibert
dguibert approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@dguibert dguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'd just need to override jre to be oraclejre8 as the new O365Interactive protocol requires JavaFX support.

@dguibert dguibert merged commit f985fb8 into NixOS:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguibert dguibert dguibert approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @dguibert @GrahamcOfBorg