Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.13.3 -> 1.13.4 #56524

Merged
merged 1 commit into from Feb 28, 2019
Merged

kubernetes: 1.13.3 -> 1.13.4 #56524

merged 1 commit into from Feb 28, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Feb 28, 2019

Motivation for this change

@GrahamcOfBorg build kubernetes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Feb 28, 2019

@GrahamcOfBorg test kubernetes.dns

@xeji
Copy link
Contributor

xeji commented Feb 28, 2019

@GrahamcOfBorg test kubernetes.rbac

@xeji xeji merged commit b8285fc into NixOS:master Feb 28, 2019
@johanot johanot mentioned this pull request Feb 28, 2019
Closed
10 tasks
xeji pushed a commit that referenced this pull request Feb 28, 2019
@johanot @xeji
kubernetes: 1.13.3 -> 1.13.4 (#56524)
2a53812 
(cherry picked from commit b8285fc)
@xeji
Copy link
Contributor

xeji commented Feb 28, 2019

backported to 19.03 in 2a53812

fpletz pushed a commit to mayflower/nixpkgs that referenced this pull request Mar 7, 2019
@johanot @fpletz
kubernetes: 1.13.3 -> 1.13.4 (NixOS#56524)
0860826 
(cherry picked from commit b8285fc)
(cherry picked from commit 2a53812)
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/kubernetes-broken-on-master-a-recurring-event/3191/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johanot @xeji @nixos-discourse @GrahamcOfBorg