pythonPackages.block-io: fix incorrect dependency version #56462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Feb 27, 2019
| version = "3.6.6"; | ||
| sha256 = "b3cb4af317d9b84f6df50f0cfa6840ba69556af637a83fd971537823e13d601a"; | ||
| }; | ||
| })) |
There was a problem hiding this comment.
We can't do that for Python packages. You should instead patch the source.
There was a problem hiding this comment.
you mean make it work with the latest version of pycryptodome ?
There was a problem hiding this comment.
Exactly. I guess the only thing that's necessary for that is patching setup.py.
There was a problem hiding this comment.
I tested it with the last pycryptodome version and opened a PR upstream, this PR is updated with the corresponding patch
nyanloutre
force-pushed
the
blockio-fix
branch
from
e18ffdb
to
f0b211d
Compare
dotlambda
reviewed
Feb 27, 2019
| @@ -9,6 +9,13 @@ buildPythonPackage rec { | |||
| sha256 = "4909d58b32ab7f93d3cd83fa4bbe4edef42ab7566f016bdb6a405a0d8b1907c9"; | |||
| }; | |||
|
|
|||
| patches = [ | |||
| (fetchpatch { | |||
| url = "https://patch-diff.githubusercontent.com/raw/BlockIo/block_io-python/pull/18.patch"; | |||
There was a problem hiding this comment.
Suggested change
| url = "https://patch-diff.githubusercontent.com/raw/BlockIo/block_io-python/pull/18.patch"; | |
| url = "https://github.com/BlockIo/block_io-python/commit/8ec0a0cd1afcfcb439d6dc306d8497dd9e4a0993.patch"; |
The content of a PR can change.
nyanloutre
force-pushed
the
blockio-fix
branch
from
f0b211d
to
5032ce4
Compare
|
@dotlambda could you backport it to 19.03 ? |
dotlambda
pushed a commit
that referenced
this pull request
Mar 26, 2019
(cherry picked from commit 64a63e5)
|
done in 0ef2bff |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This should also be backported to 19.03 to fix the build
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)