Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papis: 0.7.5 -> 0.8.1 #56463

Merged
merged 1 commit into from Feb 27, 2019
Merged

papis: 0.7.5 -> 0.8.1 #56463

merged 1 commit into from Feb 27, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 27, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @teto @dtzWill @nico202

@dotlambda dotlambda changed the title papis: 0.7.5 -> 0.8 papis: 0.7.5 -> 0.8.1 Feb 27, 2019
@dtzWill
Copy link
Member

dtzWill commented Feb 27, 2019 via email

@dtzWill
Copy link
Member

dtzWill commented Feb 27, 2019

Looks like you already did the 0.8.1 bump and shell completion for zsh works once I followed the docs 😇.

LGTM!

FWIW, for zsh completion add this to your .zshrc or so:

eval "$(_PAPIS_COMPLETE=source_zsh papis)"

Not the nix-iest but does the trick! :)

@dtzWill dtzWill merged commit 8b6b3c9 into NixOS:master Feb 27, 2019
@teto
Copy link
Member

teto commented Feb 28, 2019

didn't see it was released. As for zsh it would be even better with this in postinstall (tested)
install -D "scripts/shell_completion/click/papis.zsh" $out/share/zsh/site-functions/_papis

@dtzWill
Copy link
Member

dtzWill commented Feb 28, 2019 via email

@teto
Copy link
Member

teto commented Feb 28, 2019

my suggestion was not good, I still need to source it. Hopefully papis can change the zsh script so that it works out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants