Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to tensorflow 1.13.1 #56515

Closed
wants to merge 3 commits into from
Closed

update to tensorflow 1.13.1 #56515

wants to merge 3 commits into from

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Feb 28, 2019

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jyp jyp requested a review from FRidh as a code owner February 28, 2019 11:04
@xiorcale
Copy link
Contributor

Duplicate: #56424

@averelld averelld mentioned this pull request Mar 1, 2019
Closed
10 tasks
@averelld
Copy link
Contributor

averelld commented Mar 1, 2019

This is better and more complete, so I closed the other PR. But the lifted python 3.7 restriction should be added here, that is like the best new feature, especially since 3.7 is the NixOS default!

@FRidh
Copy link
Member

FRidh commented Mar 2, 2019

Took this and the commit from @averelld and merged them in #56669.

@FRidh FRidh closed this Mar 2, 2019
@FRidh
Copy link
Member

FRidh commented Mar 2, 2019

cherry-picked to staging-19.03 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jyp @xiorcale @averelld @FRidh @GrahamcOfBorg