Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/fish: generate autocompletions from man pages" #56439

Merged
merged 1 commit into from Feb 26, 2019
Merged

Revert "nixos/fish: generate autocompletions from man pages" #56439

merged 1 commit into from Feb 26, 2019

Conversation

dotlambda
Copy link
Member

Reverts #52464

I'm getting

$ sudo nixos-rebuild switch --upgrade
[sudo] password for rschuetz: 
unpacking channels...
building Nix...
building the system configuration...
these derivations will be built:
  /nix/store/hxapfj465a1zq9mxyqq5bs8ssmysvpg3-system-path.drv
  /nix/store/0acs3xcyncrbm8q10szwmjm1ppsbadzg-unit-polkit.service.drv
  /nix/store/c955c9b16crcx94khq6grg8impzm9k8f-dbus-1.drv
  /nix/store/gqgq09200p1y11nwp37s3q0pydadjfsr-unit-dbus.service.drv
  /nix/store/mm548j8hmr2fm8z3162hx5v2hxml99nc-unit-systemd-fsck-.service.drv
  /nix/store/0kks76hvabbz83ki1pbgjvhirapklxd2-system-units.drv
  /nix/store/7xjc2k6k6ahqvxywgsvyzhl5pz95aj6p-unit-dbus.service.drv
  /nix/store/7v7659mgd3y1jw4840qqvcdl25sn7783-user-units.drv
  /nix/store/my50yq2jrkfn4236gh97wn4fr4b36703-system-fish-completions.drv
  /nix/store/1bysir6pwkk3icv8qq44vxmc6zmavd33-etc.drv
  /nix/store/91jf5r8kajdpyls3l6wp55h9jm85yw0s-nixos-system-kurt-19.09pre170705.1233c8d9e9b.drv
building '/nix/store/hxapfj465a1zq9mxyqq5bs8ssmysvpg3-system-path.drv'...
building '/nix/store/my50yq2jrkfn4236gh97wn4fr4b36703-system-fish-completions.drv'...
collision between `/nix/store/8sj7f49hq62bgn66qkhjdiq5k1knk7pi-systemd-239.20190219/sbin/resolvconf' and `/nix/store/qrwvyvrnvvs4isjrmzpi4y8abhnlnjvx-openresolv-3.9.0/sbin/resolvconf'
collision between `/nix/store/8sj7f49hq62bgn66qkhjdiq5k1knk7pi-systemd-239.20190219/bin/resolvconf' and `/nix/store/qrwvyvrnvvs4isjrmzpi4y8abhnlnjvx-openresolv-3.9.0/bin/resolvconf'
collision between `/nix/store/4n8m05i2zjnkgxqv1i1kbgm84r52ds9l-platform-tools-28.0.1/bin/mke2fs' and `/nix/store/72j2rphh3ldz7gzjk6d88vggj781xa7h-e2fsprogs-1.44.5-bin/bin/mke2fs'
collision between `/nix/store/c4mr5y71ri1i8ryv91q755ajkyrla96f-procps-3.3.15-fish-completions/kill.fish' and `/nix/store/ybgxpd7yz9d6513gg3knwvlzfc0zy9a9-coreutils-8.30-fish-completions/kill.fish'
collision between `/nix/store/gnyad5wqf37ggwcdrp5rxjbxi8ciyx87-getent-1003.1-2008/bin/getent' and `/nix/store/p1aicp5gllvlnnr8a49i3inrgal1w812-glibc-2.27-bin/bin/getent'
collision between `/nix/store/q5lbfi48m8ghkkciwwldpxwyhp68jrmg-getconf-1003.1-2008/bin/getconf' and `/nix/store/p1aicp5gllvlnnr8a49i3inrgal1w812-glibc-2.27-bin/bin/getconf'
builder for '/nix/store/my50yq2jrkfn4236gh97wn4fr4b36703-system-fish-completions.drv' failed with exit code 25
cannot build derivation '/nix/store/1bysir6pwkk3icv8qq44vxmc6zmavd33-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/91jf5r8kajdpyls3l6wp55h9jm85yw0s-nixos-system-kurt-19.09pre170705.1233c8d9e9b.drv': 1 dependencies couldn't be built
error: build of '/nix/store/91jf5r8kajdpyls3l6wp55h9jm85yw0s-nixos-system-kurt-19.09pre170705.1233c8d9e9b.drv' failed

cc @hyperfekt @lheckemann

@hyperfekt
Copy link
Contributor

hyperfekt commented Feb 26, 2019 •
edited

see #56432. Working on it right now but feel free to revert if you don't want to wait for the fix. I feel like the quick workaround of adding checkCollisionContents = false probably isn't the right thing to do.

@dotlambda
Copy link
Member Author

feel free to revert if you don't want to wait for the fix

Since a lot of people will run into this I guess reverting makes total sense in order not to make them angry with their beloved OS.
I'm kind of shocked this has not been discovered before. If only a handful of people had tested your PR it surely would have.

I feel like the quick workaround of adding checkCollisionContents = false probably isn't the right thing to do?

I haven't looked at the code so I'm not even sure why you're considering it only a workaround.

@dotlambda dotlambda merged commit 029adf9 into master Feb 26, 2019
@dotlambda
Copy link
Member Author

Btw, it would be nice to have nixos/tests/fish.nix which

  • tests the new feature of generating completions from man pages and
  • fails in the previous situation due to collisions.

@hyperfekt
Copy link
Contributor

hyperfekt commented Feb 27, 2019 •
edited

Thank you, I added some tests. The old PR is also part of the 19.03 branch, so we should probably revert there too or alternatively merge #56446 lest it will throw errors just as unstable did.
I guess you can also close the issue, at least as soon as unstable updates.

dotlambda added a commit that referenced this pull request Feb 27, 2019
@dotlambda
Revert "nixos/fish: generate autocompletions from man pages" (#56439)
1348641 
System rebuilds currently fail due to collisions.
See also #56432.

(cherry picked from commit 029adf9)
@dotlambda dotlambda mentioned this pull request Feb 27, 2019
Closed
@dotlambda dotlambda deleted the revert-52464-fish_generate-completions branch March 13, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @hyperfekt @GrahamcOfBorg