Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mnist: init at 0.2.2 #56518

Merged
merged 2 commits into from Nov 22, 2019
Merged

pythonPackages.mnist: init at 0.2.2 #56518

merged 2 commits into from Nov 22, 2019

Conversation

dmrauh
Copy link
Contributor

@dmrauh dmrauh commented Feb 28, 2019 •
edited

Motivation for this change

Add python mnist utilities.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dmrauh dmrauh requested a review from FRidh as a code owner February 28, 2019 12:53
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.mnist python3.pkgs.mnist

@dotlambda dotlambda changed the title mnist: init at 0.2.2 pythonPackages.mnist: init at 0.2.2 Feb 28, 2019
dotlambda
dotlambda requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to maintainer-list.nix in a separate commit and change the commit message of the existing one to the PR's title.

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or, if there are no tests, set doCheck = false and add a comment with the reason.

Finally, please make the python2 build work.

pkgs/development/python-modules/mnist/default.nix Outdated Show resolved Hide resolved
@dmrauh dmrauh force-pushed the add/mnist branch 2 times, most recently from 2077059 to 2eb21c1 Compare February 28, 2019 14:13
dotlambda
dotlambda requested changes Feb 28, 2019
View reviewed changes
pkgs/development/python-modules/mnist/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mnist/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mnist/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

aanderse commented Aug 5, 2019

@dmrauh are you able to address the comments above and continue with this PR?

@dmrauh
Copy link
Contributor Author

dmrauh commented Oct 17, 2019

Please excuse my long hiatus. I hope that i have addressed all comments. The only problem i had was that some tests using sockets during check phase were failing which i had to disable in the end.

@dmrauh dmrauh force-pushed the add/mnist branch 3 times, most recently from f8e1299 to cdca919 Compare October 18, 2019 11:49
@dmrauh
Copy link
Contributor Author

dmrauh commented Oct 22, 2019

@dotlambda @aanderse do you think my PR can be merged or is there anything else to do?

@aanderse
Copy link
Member

@dmrauh I don't see any issues. Thanks for following up. @dotlambda good to go from your perspective?

jonringer
jonringer approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/56518
3 package were built:
python27Packages.mnist python37Packages.mnist python38Packages.mnist

@jonringer jonringer merged commit 3936a48 into NixOS:master Nov 22, 2019
@dmrauh
Copy link
Contributor Author

dmrauh commented Nov 22, 2019

Thanks to all reviewers for your help!

@dmrauh dmrauh deleted the add/mnist branch November 22, 2019 12:10
@jonringer
Copy link
Contributor

... it did take 8 months... that's quite a while. what's impressive to me, is that this means we've had 17k PRs in 8 months, which is averaging like 2.1k a month O.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 9.needs: reporter feedback 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dmrauh @dotlambda @aanderse @jonringer @GrahamcOfBorg @Janik-Haag