nixos/jupyter: Fix documentation example for jupyter.kernels
#56415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable loading fails when using the example for `kernels` config, due to incorrect syntax. The error being something along the lines of `path not found`.
FRidh
requested changes
Mar 3, 2019
|
If I am correct, it's indeed removing the spaces like you did, and replacing the single $ with $$. |
infinisil
reviewed
Mar 4, 2019
layus
added a commit
to layus/nixpkgs
that referenced
this pull request
Jan 31, 2020
Fixes and closes NixOS#56415 Thanks at @BenSchZA for reporting.
|
@BenSchZA Triage ping. Are you still interested in updating and getting this merged ? |
|
@layus Thanks for checking in. I've just seen the updates you made. Happy to update and get this merged. |
Thanks to @infinisil and @layus for suggestions.
layus
approved these changes
Jan 31, 2020
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
…#56415) * Fix documentation example for `jupyter.kernels` The environment variable loading fails when using the example for `kernels` config, due to incorrect syntax. The error being something along the lines of `path not found`. Thanks to @infinisil and @layus for suggestions.
jpgu-epam
pushed a commit
to jpgu-epam/nixpkgs
that referenced
this pull request
Feb 4, 2020
…#56415) * Fix documentation example for `jupyter.kernels` The environment variable loading fails when using the example for `kernels` config, due to incorrect syntax. The error being something along the lines of `path not found`. Thanks to @infinisil and @layus for suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The environment variable loading fails when using the example for
kernelsconfig, due to incorrect syntax. The error being something along the lines ofpath not found. The same is true for the loading of the relevant icons from path.This change is a simple update of the service documentation.
Things done