Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the addresses Alertmanager will listen on #56409

Merged
merged 1 commit into from Feb 26, 2019
Merged

Document the addresses Alertmanager will listen on #56409

merged 1 commit into from Feb 26, 2019

Conversation

tomfitzhenry
Copy link
Contributor

golang/go#9334 describes how net.Listen (as used by Alertmanager):

  • listens on 127.0.0.1 if the listenAddress is "localhost"
  • listens on all interfaces if the listenAddress is ""
Motivation for this change

I set listenAddress to "localhost", expecting this to support 127.0.0.1 and ::1, but Alertmanager only listened on 127.0.0.1, which broke my setup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomfitzhenry
Document the addresses Alertmanager will listen on
0d29baf 
golang/go#9334 describes how net.Listen (as used by Alertmanager):
* listens on 127.0.0.1 if the listenAddress is "localhost"
* listens on all interfaces if the listenAddress is ""
@xeji xeji merged commit 9f07fa7 into NixOS:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomfitzhenry @GrahamcOfBorg @xeji