New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins: add vim-sneak, unicode.vim, nvim-hs.vim, far.vim, vim-rsi #56503
Conversation
2d8b82e
to
3f234c1
Compare
I fixed the issue with unicode.vim (the author released a new version that fixed the problem). |
c6810dd
to
09060c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding the versions the individual plugins are initialized at to the commite (init at 2019-xx-xx
)? I know its a bit of a nitpick, but its the way we usually do it and shouldn't be much effort with a git rebase -i
.
While you're at it you could also add one more commit to update all the plugins to the latest versions, replacing #59343.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for sending you through another iteration, but nix-review
fails:
nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/timo/.cache/nix-review/pr-56503/build.nix
builder for '/nix/store/fpl1jfng1pa0skfjpk2qpy70vwx3i1y0-vimplugin-nvim-hs-vim-2019-01-05.drv' failed with exit code 1; last 10 log lines:
unpacking sources
unpacking source archive /nix/store/nkfkjw60szwv9c83ci8311lz26k6ixv9-source
source root is source
patching sources
configuring
building
installing
Building help tags
Error detected while processing command line:
E154: Duplicate tag "nvim-hs" in file /nix/store/8hskf9qs40h426hbyxgvxkjrxhlk6nzi-vimplugin-nvim-hs-vim-2019-01-05/share/vim-plugins/nvim-hs-vim/doc/nvim-hs.txtFailed to build help tags!
95532ab
to
68f65d4
Compare
i tried to address your reviews |
|
For linux I chose zenity to generate the popups (yad can be used too). Other buildInputs are needed for macos.
I filed an issue for nvim-hs-vim and dropped it from this PR. The current darwin failure seems unrelated and due to a nixpkgs master darwin failure if I trust the recent issues. |
Thank you :) |
that's a super cool merge thanks. |
You're welcome. You are doing good work and are generally responsive to reviews. It's a shame this PR was left to bitrot for so long. Feel free to ping me in the future if one of your PRs is ready for merge (i.e. at least passes ofBorg and |
There is a warning with unicode.vim not being able to write/cache results but it works. Might need some upstream changes.Motivation for this change
it's a pain to download unicode data as I have netrw disabled.
vim-sneak is very convenient
Waiting for #56191 to be able to update plugins,Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)