Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scfbuild: bump to latest git (Jun 2017) #56471

Merged
merged 1 commit into from Mar 4, 2019
Merged

scfbuild: bump to latest git (Jun 2017) #56471

merged 1 commit into from Mar 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 27, 2019

No release tags on the repo, unclear how versioning works,
keeping version number reported in repo for now.

Users of this (such as twemoji-color-font) have build instructions
that always grab latest git revision so we should probably do so.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
scfbuild: bump to latest git (Jun 2017)
d1fdcf6 
No release tags on the repo, unclear how versioning works,
keeping version number reported in repo for now.

Users of this (such as twemoji-color-font) have build instructions
that always grab latest git revision so this seems appropriate.
@dtzWill dtzWill merged commit df9e1fa into NixOS:master Mar 4, 2019
@dtzWill dtzWill deleted the update/scfbuild-2017 branch March 4, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg