Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emojione: 1.3 -> 1.4 #56476

Merged
merged 1 commit into from Mar 4, 2019
Merged

emojione: 1.3 -> 1.4 #56476

merged 1 commit into from Mar 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 27, 2019

Motivation for this change

https://github.com/eosrei/emojione-color-font/releases/tag/v1.4

twemoji-color-font is suggested as replacement for unicode 11 and such,
but as long as we have this expression might as well use latest.

(Suggestion is in the release notes on the linked tag)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
emojione: 1.3 -> 1.4
75fa4e2 
https://github.com/eosrei/emojione-color-font/releases/tag/v1.4

twemoji-color-font is suggested as replacement for unicode 11 and such,
but as long as we have this expression might as well use latest.
@xeji
Copy link
Contributor

xeji commented Feb 28, 2019

Yes, doesn't hurt to update this one last time.

@GrahamcOfBorg build emojione

@dtzWill dtzWill merged commit f947c77 into NixOS:master Mar 4, 2019
@dtzWill dtzWill deleted the update/emojione-1.4 branch March 4, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @xeji @dasJ @GrahamcOfBorg