Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: update default 1.67 -> 1.69 #56479

Merged
merged 2 commits into from Nov 12, 2019
Merged

boost: update default 1.67 -> 1.69 #56479

merged 2 commits into from Nov 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 27, 2019

Motivation for this change

Doesn't appear to be a reason to stay with older version,
this was only done when adding new versions to keep those
PR's simple and low-impact.

While upgrading, remove some pinned versions that appear
to be no longer necessary.

Cleanup was somewhat ad-hoc but the packages changed
were build-tested at least.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

I like how the rebuild-linux 1001-2500 label is in an understatement-grey :)
Maybe re-base to staging first? Bumping the boost default version often comes with a lot of broken builds.

@FRidh FRidh added this to the 19.09 milestone Sep 1, 2019
@FRidh
Copy link
Member

FRidh commented Sep 1, 2019

Branch-off is next week. I guess it will be too late for this change if failing builds are expected?

@disassembler disassembler changed the base branch from master to staging September 2, 2019 04:53
@FRidh FRidh added this to New in Staging Oct 24, 2019
@FRidh FRidh modified the milestones: 19.09, 20.03 Oct 24, 2019
@FRidh FRidh moved this from New to Needs review in Staging Oct 24, 2019
@FRidh FRidh merged commit 35a537d into NixOS:staging Nov 12, 2019
Staging automation moved this from Needs review to Done Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @markuskowa @FRidh @infinisil @GrahamcOfBorg