Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy: 1.16.1 -> 1.16.2 #56473

Merged
merged 1 commit into from Mar 1, 2019
Merged

numpy: 1.16.1 -> 1.16.2 #56473

merged 1 commit into from Mar 1, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 27, 2019

Motivation for this change

https://github.com/numpy/numpy/releases/tag/v1.16.2

Sending to staging regardless of rebuild impact
because master doesn't have 1.16.1 yet :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner February 27, 2019 19:55
@FRidh FRidh self-assigned this Feb 27, 2019
@FRidh
Copy link
Member

FRidh commented Feb 27, 2019

Yes we first need to get the big staging-next merge into master and then in staging-19.03...

@FRidh FRidh merged commit e94519a into NixOS:staging Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @GrahamcOfBorg