Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyunbound: 1.7.3 -> 1.9.0 #56418

Merged
merged 1 commit into from Apr 14, 2019
Merged

pyunbound: 1.7.3 -> 1.9.0 #56418

merged 1 commit into from Apr 14, 2019

Conversation

leenaars
Copy link
Contributor

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build unbound

tomberek
tomberek approved these changes Apr 14, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds. Single reverse dependency seems to function well. (non-NixOS)

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@joachifm joachifm merged commit 8ab8ef8 into NixOS:master Apr 14, 2019
@vcunat vcunat changed the title Unbound: 1.8.3 -> 1.9.0 pyunbound: 1.8.3 -> 1.9.0 Apr 14, 2019
@vcunat vcunat changed the title pyunbound: 1.8.3 -> 1.9.0 pyunbound: 1.7.3 -> 1.9.0 Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leenaars @joachifm @nixos-discourse @tomberek @infinisil @GrahamcOfBorg