Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv: fix python loading issue #56495

Merged
merged 1 commit into from Mar 6, 2019
Merged

pipenv: fix python loading issue #56495

merged 1 commit into from Mar 6, 2019
+29 −18

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 27, 2019

Motivation for this change

Fixes #56481

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Feb 28, 2019
View reviewed changes
pkgs/development/tools/pipenv/default.nix
};
}
makeWrapperArgs = [
"--set PYTHONPATH \"$PYTHONPATH\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose pipenv or virtualenv will unset PYTHONPATH after creating an env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarzon can you check this?

@zarybnicky
Copy link

zarybnicky commented Mar 6, 2019 •
edited

I can confirm that this fixes virtualenv creation (e.g. pipenv --python 3) and doesn't break virtualenv usage.

@zimbatm zimbatm merged commit b1f767e into NixOS:master Mar 6, 2019
@zimbatm zimbatm deleted the pipenv-fix branch March 6, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @zarybnicky @FRidh @GrahamcOfBorg