emscripten: 1.37.36 -> 1.38.28 #56406

TomSmeets · 2019-02-26T10:31:09Z

Motivation for this change

The 1.37.36 version is almost a year old.

Issues

When running nox-review wip the only package that fails is meguca. Maybe just updating this package could help. @Chiiruno

Things done

Tested with a personal project.
Build everything in emscriptenPackages

qknight · 2019-02-26T11:18:28Z

if emscriptenPackages build this looks good and can be merged when done.

Chiiruno · 2019-02-26T20:03:48Z

I will update my package(s) tomorrow, today isn't good.
Thanks for the heads up!

TomSmeets · 2019-03-10T09:13:26Z

Did you manage to update your package meguca @Chiiruno ?

Chiiruno · 2019-03-10T14:15:55Z

No, I completely forgot.
I'll update now, since I have time.

Chiiruno · 2019-03-10T15:09:28Z

Depends on bakape/shamichan#999

Chiiruno · 2019-03-12T15:48:31Z

I get this error with 1.37.36, may change with this update, will test.

too long and irrelevant

Chiiruno · 2019-03-12T16:12:42Z

I get the same(?) error with 1.38.28.

mkdir -p www/wasm
make -C client_cpp
make[1]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp'
rm -f *.wasm *.wast *.js *.wasm.map *.js
make -C brunhild
make[2]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
emcc view.cc -o view.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc util.cc -o util.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc mutations.cc -o mutations.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc node.cc -o node.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc events.cc -o events.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc init.cc -o init.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: mutations.bc] Error 1
make[2]: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: node.bc] Error 1
make[2]: *** [Makefile:10: util.bc] Error 1
make[2]: *** [Makefile:10: init.bc] Error 1
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
Traceback (most recent call last):
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/emcc.py", line 41, in <module>
    from tools import shared, system_libs, client_mods, js_optimizer, jsrun
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 1006, in <module>
    check_vanilla()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/shared.py", line 981, in check_vanilla
    is_vanilla_file = temp_cache.get('is_vanilla', get_vanilla_file, extension='.txt')
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 106, in get
    self.acquire_cache_lock()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/cache.py", line 60, in acquire_cache_lock
    self.filelock.acquire(60)
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 240, in acquire
    self._acquire()
  File "/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/tools/filelock.py", line 360, in _acquire
    fd = os.open(self._lock_file, open_mode)
OSError: [Errno 2] No such file or directory: '/homeless-shelter/.emscripten_cache.lock'
make[2]: *** [Makefile:10: events.bc] Error 1
make[2]: *** [Makefile:10: view.bc] Error 1
make[2]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
make[1]: *** [Makefile:21: all] Error 2
make[1]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:26: wasm] Error 2
builder for '/nix/store/d6fgx0mxy2040s0bsq2cdd8x37ljannn-meguca-unstable-2019-03-12.drv' failed with exit code 2
error: build of '/nix/store/d6fgx0mxy2040s0bsq2cdd8x37ljannn-meguca-unstable-2019-03-12.drv' failed

Chiiruno · 2019-03-12T16:15:31Z

Any thoughts on this @bakape?
Might be a meguca problem, but not sure.

Chiiruno · 2019-03-12T16:20:44Z

Okay, I fixed the homeless-shelter thing again, different error with this commit's emscripten.

mkdir -p www/wasm
make -C client_cpp
make[1]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp'
rm -f *.wasm *.wast *.js *.wasm.map *.js
make -C brunhild
make[2]: Entering directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
emcc view.cc -o view.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc util.cc -o util.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc mutations.cc -o mutations.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc node.cc -o node.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc events.cc -o events.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emcc init.cc -o init.bc -std=c++1z --bind -O3 -g0 --llvm-lto 3 -I/build/go/src/github.com/bakape/meguca/client_cpp/json/include -Wall -Wextra -Wno-switch -Wno-unused-parameter -Werror
emscripten:INFO: generating system asset: is_vanilla.txt... (this will be cached in "/build/.emscripten_cache/is_vanilla.txt" for subsequent builds)
emscripten:INFO:  - ok
In file included from node.cc:1:
In file included from ./node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: node.bc] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from view.cc:1:
In file included from ./view.hh:3:
In file included from ./events.hh:3:
In file included from ./../src/../brunhild/node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: view.bc] Error 1
In file included from events.cc:1:
In file included from ./events.hh:3:
In file included from ./node.hh:3:
In file included from ./util.hh:4:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string:477:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/string_view:176:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/__string:56:
In file included from /nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/algorithm:643:
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:58: error: destructor called on non-final 'brunhild::Node' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1727:18: note: in instantiation of member function 'std::__2::allocator<brunhild::Node>::destroy' requested here
            {__a.destroy(__p);}
                 ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1595:14: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::__destroy<brunhild::Node>' requested here
            {__destroy(__has_destroy<allocator_type, _Tp*>(), __a, __p);}
             ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:413:25: note: in instantiation of function template specialization 'std::__2::allocator_traits<std::__2::allocator<brunhild::Node> >::destroy<brunhild::Node>' requested here
        __alloc_traits::destroy(__alloc(), _VSTD::__to_raw_pointer(--__soon_to_be_end));
                        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:356:29: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::__destruct_at_end' requested here
    void clear() _NOEXCEPT {__destruct_at_end(__begin_);}
                            ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/vector:441:9: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::clear' requested here
        clear();
        ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/iterator:1425:74: note: in instantiation of member function 'std::__2::__vector_base<brunhild::Node, std::__2::allocator<brunhild::Node> >::~__vector_base' requested here
    template <class _Tp, class _Alloc> friend class _LIBCPP_TEMPLATE_VIS vector;
                                                                         ^
/nix/store/8rzk632j5y8cbn23fdj82lhyzidjyjfl-emscripten-1.38.28/share/emscripten/system/include/libcxx/memory:1860:64: note: qualify call to silence this warning
    _LIBCPP_INLINE_VISIBILITY void destroy(pointer __p) {__p->~_Tp();}
                                                               ^
1 error generated.
shared:ERROR: compiler frontend failed to generate LLVM bitcode, halting
make[2]: *** [Makefile:10: events.bc] Error 1
make[2]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp/brunhild'
make[1]: *** [Makefile:21: all] Error 2
make[1]: Leaving directory '/build/go/src/github.com/bakape/meguca/client_cpp'
make: *** [Makefile:26: wasm] Error 2
builder for '/nix/store/p5kap6knai1r54hm9rjca5bpjhpdpklk-meguca-unstable-2019-03-12.drv' failed with exit code 2
error: build of '/nix/store/p5kap6knai1r54hm9rjca5bpjhpdpklk-meguca-unstable-2019-03-12.drv' failed

Chiiruno · 2019-03-12T17:11:00Z

Okay interesting, emscripten compiles meguca on 1.37.36, but not on this commit.

bakape · 2019-03-12T17:58:11Z

You can ignore the WASM client for now. It has been postponed to v6-7.

…

On Tue, 12 Mar 2019, 19:11 チルノ, ***@***.***> wrote: Okay interesting, emscripten compiles on 1.37.36, but not on this commit. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#56406 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHfPsECuwwQjr5mgoO1I-G_WBqrU7T10ks5vV9-pgaJpZM4bR2eF> .

TomSmeets · 2019-04-18T09:55:24Z

Can this be merged?

emscripten: 1.37.36 -> 1.38.28

5ef3645

GrahamcOfBorg requested review from qknight and matthewbauer February 26, 2019 10:49

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Feb 26, 2019

TomSmeets marked this pull request as ready for review February 26, 2019 17:26

Chiiruno mentioned this pull request Mar 12, 2019

Init: statik, Update: easyjson, quicktemplate, nodePackages: meguca, meguca, hydron #57527

Merged

10 tasks

infinisil added the 8.has: package (update) label Mar 30, 2019

matthewbauer merged commit f0cba0b into NixOS:master Apr 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

emscripten: 1.37.36 -> 1.38.28 #56406

emscripten: 1.37.36 -> 1.38.28 #56406

TomSmeets commented Feb 26, 2019

qknight commented Feb 26, 2019

Chiiruno commented Feb 26, 2019

TomSmeets commented Mar 10, 2019

Chiiruno commented Mar 10, 2019

Chiiruno commented Mar 10, 2019

Chiiruno commented Mar 12, 2019 •

edited

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019 •

edited

bakape commented Mar 12, 2019 via email

TomSmeets commented Apr 18, 2019

emscripten: 1.37.36 -> 1.38.28 #56406

emscripten: 1.37.36 -> 1.38.28 #56406

Conversation

TomSmeets commented Feb 26, 2019

Motivation for this change

Issues

Things done

qknight commented Feb 26, 2019

Chiiruno commented Feb 26, 2019

TomSmeets commented Mar 10, 2019

Chiiruno commented Mar 10, 2019

Chiiruno commented Mar 10, 2019

Chiiruno commented Mar 12, 2019 • edited

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019

Chiiruno commented Mar 12, 2019 • edited

bakape commented Mar 12, 2019 via email

TomSmeets commented Apr 18, 2019

Chiiruno commented Mar 12, 2019 •

edited

Chiiruno commented Mar 12, 2019 •

edited