Skip to content

Update jetbrains editors #56453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 28, 2019
Merged

Update jetbrains editors #56453

merged 12 commits into from
Mar 28, 2019
+25 −25

Conversation

averelld
Copy link
Contributor

Motivation for this change

Update via script. Only idea-ultimate has been tested.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@averelld averelld requested a review from edwtjo as a code owner February 27, 2019 10:34
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 27, 2019
@freezeboy
Copy link
Contributor

Wouldn't be nice to include the darwin versions at the same time?

@averelld
Copy link
Contributor Author

Right now they aren't packaged afaik. We don't even have 32bit support, but I guess it's worth an issue to add darwin support, there's an old TODO comment about that in the jetbrains-jdk derivation.

@freezeboy
Copy link
Contributor

freezeboy commented Feb 27, 2019 •
edited
Loading

and I hadn't looked at the nix expression + the update script, but it would also need quite a refactor to handle both platforms 😞

@artemist
Copy link
Member

I believe this is ready to be merged, although I don't have the authority to do so.

@aanderse
Copy link
Member

@edwtjo @loskutov @miltador as listed maintainers for the packages involved here is anything else required from your perspectives to get this merged?

@averelld averelld force-pushed the jetbrains-updates branch from bbcfe6f to c3a85de Compare March 25, 2019 10:01
Averell Dalton added 12 commits March 28, 2019 15:43
@averelld averelld force-pushed the jetbrains-updates branch from c3a85de to 6c011a0 Compare March 28, 2019 15:23
@averelld
Copy link
Contributor Author

averelld commented Mar 28, 2019 •
edited
Loading

This has been sitting around for a while now, but there's also #58478 and #58392 (Older versions, the webstorm issue seems gone with 2019.1).
Also there's a (not required) JDK update here too which could be picked separately.

@flokli
Copy link
Contributor

flokli commented Mar 28, 2019

I did build all of them, tried out webstorm and pycharm. Thanks, and sorry for keeping this PR open so long…

@flokli flokli merged commit b243d81 into NixOS:master Mar 28, 2019
@flokli
Copy link
Contributor

flokli commented Mar 28, 2019

backported to 19.03 in dd9a78c, 686016b, d5b1fb9, 4b4b595, 9a66b56, d1f4e6e, e7ec56b, 107af48, e809249, e93b568, 49f2712 and 9ebce7f.

This was referenced Mar 28, 2019
Closed
Closed
@averelld averelld deleted the jetbrains-updates branch March 29, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@averelld @freezeboy @artemist @aanderse @flokli @GrahamcOfBorg