nixos/nextcloud: Update recommended nginx settings #56496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachp
changed the title
dasJ
requested changes
Feb 28, 2019
aanderse
requested changes
Mar 1, 2019
|
Yes! Which is great for reproducible systems! |
This updates the configuration to the recommendations in https://docs.nextcloud.com/server/15/admin_manual/installation/nginx.html
This allows to have a php configuration for nextcloud that is independent of the global configuration.
It needs to match the version in phpfm which is hard coded. So there is no point in being able to change it.
bachp
force-pushed
the
nextcloud-nginx-recommended
branch
from
cd8774e
to
390b610
Compare
fpletz
added
the
9.needs: port to stable
fpletz
approved these changes
Mar 2, 2019
|
@GrahamcOfBorg test nextcloud.basic nextcloud.with-mysql-and-memcached nextcloud.with-postgresql-and-redis |
10 tasks
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update default configuration to match the latest recommendations from Nextcloud: https://docs.nextcloud.com/server/15/admin_manual/installation/nginx.html
To get rid of all the warnings the
imagickPHP module is enabled too.Also update to PHP 7.3 as this is officially supported by Nextcloud 15: https://docs.nextcloud.com/server/15/admin_manual/installation/system_requirements.html
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)