Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: dd94b0724cfc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 8293ab846144
Choose a head ref
  • 2 commits
  • 131 files changed
  • 2 contributors

Commits on Feb 26, 2019

  1. treewide: use runtimeShell instead of stdenv.shell whenever possible 

    Whenever we create scripts that are installed to $out, we must use runtimeShell
in order to get the shell that can be executed on the machine we create the
package for. This is relevant for cross-compiling. The only use case for
stdenv.shell are scripts that are executed as part of the build system.
Usages in checkPhase are borderline however to decrease the likelyhood
of people copying the wrong examples, I decided to use runtimeShell as well.
    @Mic92
    Mic92 committed Feb 26, 2019
    Copy the full SHA
    dadc7eb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #56408 from Mic92/runtime-shell 

    treewide: use runtimeShell instead of stdenv.shell whenever possible
    @Ericson2314
    Ericson2314 committed Feb 26, 2019
    Copy the full SHA
    8293ab8 View commit details
    Browse the repository at this point in the history