New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: use runtimeShell instead of stdenv.shell whenever possible for 19.03 #56441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow settign gvim wrapper name independently of vim wrapper name. * Allow setting vim wrapper name independently of derivation name. * Refactor multiple places where name was checked for null with default value.
phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: init at 5.6.0
vim_customizable: Include manpages in the output
Non reply emails just look so shady :)
smlnj: 110.84 -> 110.85
nodePackages.tsun: init at 0.4.0
mattermost-desktop: 4.1.2 -> 4.2.0
a vlaue between 0 and 4 to help debug problems
Upstream fixes: - Unregister socket as soon as we know that no rule matches. I also removed the encode_rules() function which was an artifact left in version 2.0.0. Built and tested on i686-linux and x86_64-linux. Signed-off-by: aszlig <aszlig@nix.build>
cups-brother-hl3140cw: init at 1.1.4-0
slurp: 1.0.1 -> 1.1.0
Whenever we create scripts that are installed to $out, we must use runtimeShell in order to get the shell that can be executed on the machine we create the package for. This is relevant for cross-compiling. The only use case for stdenv.shell are scripts that are executed as part of the build system. Usages in checkPhase are borderline however to decrease the likelyhood of people copying the wrong examples, I decided to use runtimeShell as well.
Ericson2314
requested review from
edolstra,
FRidh and
infinisil
as code owners
February 26, 2019 23:05
Ericson2314
requested review from
matthewbauer,
nbp and
Profpatsch
as code owners
February 26, 2019 23:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #56408.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)