Revert "Merge pull request #54980 from danbst/etc-relative" #56507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@7c6f434c can you backport this to 19.03? |
|
I have no idea what is going on. I would expect you to just directly push a revert directly, given that you didn't even wait for ofBorg checks — and then you could as well push the rever to both branches. Whatever, reverted in |
|
@7c6f434c I can't push to master branch (no rights?), so I have to do PRs... |
|
🤔 maybe that's because there is policy about signed commits?.. |
|
Nope, that's definitely not policy on signed commits.
I just thought you were not a readonly member (I thought this is still a rare state).
@domenkozar Maybe this could be changed?
|
|
@7c6f434c figured this out. I had |
|
Actually, I push via HTTPS, but using a push token instead of password. |
coreyoconnor
added a commit
to coreyoconnor/nixpkgs
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b91fa4, reversing
changes made to 183919a.
Motivation for this change
#56278
#54980 (comment)
#54980 (comment)
https://discourse.nixos.org/t/nixos-rebuild-switch-upgrade-error-directory-contains-user-files-symlinking-may-fail/2266
The
isStaticcheck now doesn't work, which leads to warnings