Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vifm: works on macos too #56506

Merged
merged 1 commit into from Feb 28, 2019
Merged

vifm: works on macos too #56506

merged 1 commit into from Feb 28, 2019

Conversation

Quiark
Copy link
Contributor

@Quiark Quiark commented Feb 28, 2019

Motivation for this change

Package says linux only but it works on mac

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Feb 28, 2019
@Quiark Quiark marked this pull request as ready for review February 28, 2019 06:09
@peterhoeg
Copy link
Member

@GrahamcOfBorg build vifm

@peterhoeg
Copy link
Member

Thank you for your contribution @Quiark! I don't have a mac to test it out here so let's see what the build bot comes back with.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build vifm

@7c6f434c 7c6f434c merged commit 7e25fb2 into NixOS:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Quiark @peterhoeg @7c6f434c @GrahamcOfBorg @Janik-Haag