Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #56408 mess (runtimeShell) #56509

Merged
merged 4 commits into from Feb 28, 2019
Merged

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://hydra.nixos.org/build/89668091

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92 @Ericson2314 You owe me one! It's sad I have to clean up after you.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 28, 2019
@dotlambda dotlambda merged commit c2f358e into NixOS:master Feb 28, 2019
@dotlambda
Copy link
Member Author

Yay! 🎉
https://hydra.nixos.org/build/89668286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants