Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libguestfs: build without the appliance #56448

Merged
merged 1 commit into from Mar 6, 2019
Merged

libguestfs: build without the appliance #56448

merged 1 commit into from Mar 6, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Feb 27, 2019

Motivation for this change

libguestfs-appliance is huge (4g) and can't be built on Hydra. I'd like to be able to fetch a prebuilt libguestfs, and don't need the appliance. Not sure about knock-on effects here, though. Also I'd like a backport to 19.03 :D

cc @offlinehacker for review please :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

samueldr commented Feb 27, 2019 •
edited

@NixOS/backports for whenever this is merged. (This'll probably need 2e23d72 too.)

@grahamc
Copy link
Member Author

grahamc commented Feb 27, 2019

Already backported that one :) 4e7135a

@samueldr
Copy link
Member

The good thing is that since this never built on Hydra, nothing must really be depending on it inside Nixpkgs, but this is also the bad thing, breakage could exist for external users.

Looking at the derivation, the appliance

  • Is used to enable checks in install phase
  • is linked to $out/lib{,64}/guestfs

Maybe it's possible to have our cake and eat it too, by somehow allowing this to happen after the derivation is built, allowing the lengthy build of libguestfs to be re-used with any appliance? (Though, thinking about it I'm willing to bet that $out is used to refer to that path :/) Any similar trickery in Nixpkgs to use as inspiration?

@etu
Copy link
Contributor

etu commented Feb 27, 2019

@samueldr Vagrant depends on it and fails to build on current unstable and presumably 19.03 as well. See #55656.

@grahamc
Copy link
Member Author

grahamc commented Feb 27, 2019 via email

@wkral wkral mentioned this pull request Mar 1, 2019
Closed
@grahamc grahamc merged commit a530455 into NixOS:master Mar 6, 2019
@grahamc grahamc deleted the libguestfs branch March 6, 2019 14:02
@minijackson minijackson mentioned this pull request Jan 5, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @samueldr @etu @GrahamcOfBorg