Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejabberd: 18.12.1 -> 19.02 #56464

Merged
merged 1 commit into from Apr 8, 2019
Merged

ejabberd: 18.12.1 -> 19.02 #56464

merged 1 commit into from Apr 8, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Feb 27, 2019 •
edited

Motivation for this change

Update package ejabberd to version 19.02

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 9, 2019

@GrahamcOfBorg build ejabberd

@aanderse
Copy link
Member

@abbradar @svanderburg as the listed maintainers of this package is there anything else required from your perspectives to get this merged?

aanderse
aanderse approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PS. bonus points for anyone who makes a nixos module to test this module.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/13

@ryantm ryantm merged commit 4819c7d into NixOS:master Apr 8, 2019
@Izorkin Izorkin deleted the ejabberd branch April 8, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Izorkin @aanderse @nixos-discourse @ryantm @infinisil @GrahamcOfBorg