Skip to content

go_1_12: init at 1.12beta2 #54950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

go_1_12: init at 1.12beta2 #54950

wants to merge 1 commit into from
+304 −0

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Jan 30, 2019 •
edited
Loading

Motivation for this change

Go 1.12 is coming out by early March at the latest, and I'd like us to be ready to pounce on that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@edef1c edef1c added the 2.status: work-in-progress This PR isn't done label Jan 30, 2019
@edef1c
Copy link
Member Author

edef1c commented Jan 30, 2019

@GrahamcOfBorg build go_1_12

@edef1c
Copy link
Member Author

edef1c commented Jan 30, 2019

I'm kind of mystified by the fetchzip failure, I'm hoping that's just nondeterminism on GitHub's end or something.
@GrahamcOfBorg build go_1_12

@edef1c edef1c force-pushed the go1.12beta2 branch 2 times, most recently from 6e6179a to ca70971 Compare January 30, 2019 21:14
@edef1c
Copy link
Member Author

edef1c commented Jan 30, 2019

I've switched src to fetch from official release tarballs rather than GitHub, I'm hoping that resolves the inconsistency.
@GrahamcOfBorg build go_1_12

@edef1c
go_1_12: init at 1.12beta2

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 916062A1C4748647
Learn about vigilant mode
ce7e6e1
@edef1c edef1c removed the 2.status: work-in-progress This PR isn't done label Feb 10, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from Mic92 February 10, 2019 09:39
@edef1c
Copy link
Member Author

edef1c commented Feb 10, 2019

eep, seems the bot doesn't notice WIP tag removals
@GrahamcOfBorg build go_1_12

Mic92
Mic92 reviewed Feb 10, 2019
View reviewed changes
pkgs/development/compilers/go/1.12.nix
sed -i 's,strings.Contains(.*sysctl.*,true {,' src/cmd/dist/util.go
sed -i 's,"/etc","'"$TMPDIR"'",' src/os/os_test.go
sed -i 's,/_go_os_test,'"$TMPDIR"'/_go_os_test,' src/os/path_test.go

Copy link
Member

@Mic92 Mic92 Feb 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some more of these on macOS:

##### os/user with tag osusergo
--- FAIL: TestCurrent (0.01s)
    user_test.go:22: Current: user: Current not implemented on darwin/amd64 (got (*user.User)(nil))
--- FAIL: TestLookup (0.00s)
    user_test.go:65: Current: user: Current not implemented on darwin/amd64
--- FAIL: TestLookupId (0.00s)
    user_test.go:86: Current: user: Current not implemented on darwin/amd64
FAIL
FAIL    os/user 0.050s
2019/02/10 10:06:56 Failed: exit status 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have no clue, why we it suddenly does not return a user their.

Copy link
Member Author

@edef1c edef1c Feb 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so much "not implemented" as "we ran the implementation, and it bailed because we're missing some files/env vars it expected to find". Just disabling the tests will do, but I might be able to do a prettier fix.

@edef1c edef1c closed this Mar 9, 2019
@edef1c edef1c deleted the go1.12beta2 branch March 9, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@orivej orivej

@cstrahan cstrahan

Assignees
No one assigned
Labels
6.topic: golang 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edef1c @Mic92 @orivej @GrahamcOfBorg