New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/coredns: init #54931
nixos/coredns: init #54931
Conversation
9efb355
to
e2b5530
Compare
e2b5530
to
7602830
Compare
7602830
to
0648935
Compare
This misses an entry in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix |
0648935
to
9e950a4
Compare
9e950a4
to
488ce53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @DeltaEvo it took a little bit longer to have a look on this module. I am using it successful on my local machine for dns resolution. Thanks a lot for the effort. @infinisil & @danbst can we merge this PR. Although it won't make it to 19.03 anymore, we could request a backport up then.
Motivation for this change
Add nixos module for coredns
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)