Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/coredns: init #54931

Merged
merged 1 commit into from Mar 1, 2019
Merged

nixos/coredns: init #54931

merged 1 commit into from Mar 1, 2019

Conversation

DeltaEvo
Copy link
Member

@DeltaEvo DeltaEvo commented Jan 30, 2019

Motivation for this change

Add nixos module for coredns

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
@DeltaEvo DeltaEvo force-pushed the coredns_nixos branch 2 times, most recently from 9efb355 to e2b5530 Compare January 30, 2019 12:54
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/coredns.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/coredns.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/coredns.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/coredns.nix Show resolved Hide resolved
nixos/modules/services/networking/coredns.nix Outdated Show resolved Hide resolved
@danbst
Copy link
Contributor

danbst commented Feb 5, 2019

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @DeltaEvo it took a little bit longer to have a look on this module. I am using it successful on my local machine for dns resolution. Thanks a lot for the effort. @infinisil & @danbst can we merge this PR. Although it won't make it to 19.03 anymore, we could request a backport up then.

@danbst danbst merged commit b381c27 into NixOS:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants