Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.django_1_8: mark as insecure #54937

Merged
merged 1 commit into from Jan 30, 2019
Merged

python.pkgs.django_1_8: mark as insecure #54937

merged 1 commit into from Jan 30, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

Since CVE-2018-14574 and CVE-2019-3498 affect 1.11, it is very likely
they also apply to 1.8. However, Django 1.8 has reached EOL in April
2018 and the patches were not backported.

related to #52679

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @rickynils @offlinehacker @basvandijk

python.pkgs.django_1_8: mark as insecure
72d6886 
Since CVE-2018-14574 and CVE-2019-3498 affect 1.11, it is very likely
they also apply to 1.8. However, Django 1.8 has reached EOL in April
2018 and the patches were not backported.
@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 30, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner January 30, 2019 13:40
@grahamc
Copy link
Member

grahamc commented Jan 30, 2019

Should we just delete it from master, and apply this patch to stable?

@dotlambda
Copy link
Member Author

Should we just delete it from master, and apply this patch to stable?

It's still used by graphite-web. See #52679.

@grahamc
Copy link
Member

grahamc commented Jan 30, 2019

Yikes. Okay. Thanks. We should keep #52679 open until we can delete it.

@dotlambda dotlambda merged commit c6e0857 into NixOS:master Jan 30, 2019
dotlambda added a commit that referenced this pull request Jan 30, 2019
@dotlambda
python.pkgs.django_1_8: mark as insecure (#54937)
f944ffe 
Since CVE-2018-14574 and CVE-2019-3498 affect 1.11, it is very likely
they also apply to 1.8. However, Django 1.8 has reached EOL in April
2018 and the patches were not backported.

(cherry picked from commit c6e0857)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@dotlambda dotlambda deleted the django_1_8-insecure branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @grahamc @samueldr @GrahamcOfBorg