New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: unicode characters in Romanian town names #7141
Conversation
8aed34b
to
05e016d
Compare
heh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this also seems alright.
And I see... what LordAre means... the commit message needs to be changed to NOT contain the characters in question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the non-unicode characters sadly need to be removed from the commit message.
Many of these town names were using the 'a with ~ above it' character, which should actually by 'a with u above it'. There were other missing accents as well which I've added.
05e016d
to
98cad7a
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, now the commit message checker is also satisfied...
Many of these town names were using the 'a with ~ above it' character, which should actually by 'a with u above it'. There were other missing accents as well which I've added.
Many of these town names were using the 'a with ~ above it' character, which should actually by 'a with u above it'. There were other missing accents as well which I've added.
Many of these town names were using the 'a with ~ above it' character, which should
actually by 'a with u above it'. There were other missing accents as well which I've
added.