Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unicode characters in Romanian town names #7141

Merged
merged 1 commit into from Jan 30, 2019

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Jan 30, 2019

Many of these town names were using the 'a with ~ above it' character, which should
actually by 'a with u above it'. There were other missing accents as well which I've
added.

@LordAro
Copy link
Member

LordAro commented Jan 30, 2019

Message contains non-ASCII characters or tabs: 'Many of these town names were using the '\xe3' character, which should'

heh.

Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this also seems alright.

And I see... what LordAre means... the commit message needs to be changed to NOT contain the characters in question.

Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the non-unicode characters sadly need to be removed from the commit message.

Many of these town names were using the 'a with ~ above it' character,
which should actually by 'a with u above it'. There were other missing
accents as well which I've added.
@nikolas
Copy link
Member Author

nikolas commented Jan 30, 2019

done

Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now the commit message checker is also satisfied...

@planetmaker planetmaker merged commit 8334a57 into OpenTTD:master Jan 30, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Many of these town names were using the 'a with ~ above it' character,
which should actually by 'a with u above it'. There were other missing
accents as well which I've added.
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Many of these town names were using the 'a with ~ above it' character,
which should actually by 'a with u above it'. There were other missing
accents as well which I've added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants