Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] dockerTools: unpin go version #54944

Merged
merged 1 commit into from Jan 31, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jan 30, 2019

Motivation for this change

This is a port to stable of 4d8bb9a.

With the recent deprecation of Go1.9 the dockerTools stopped working on 18.09.

We can safely lift the go version constraints on dockerTools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The linked PR has been merged, and in fact dockerTools has upgraded to the
latest `go1.11` compiler:

moby/moby#35739
moby/moby#37358
(cherry picked from commit 4d8bb9a)
@andir
Copy link
Member Author

andir commented Jan 30, 2019

@GrahamcOfBorg test docker-tools

@andir andir merged commit cdf9d7c into NixOS:release-18.09 Jan 31, 2019
@andir andir deleted the 18.09/dockerTools branch January 31, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants