Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beam-packages: add erlang_nox #54928

Closed
wants to merge 1 commit into from
Closed

Conversation

DeltaEvo
Copy link
Member

Motivation for this change

Add beam package with erlang_nox variation, this is useful to have an elixir without x dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789
Copy link
Contributor

cw789 commented Mar 1, 2019

Hi I'm also interested in using the erlang_nox version.
I'm currently using elixir = pkgs.beam.packages.erlangR21.elixir_1_8;.
But with your version I think I'm not able to use erlangRxx_nox - only the default version (currently erlangR20).

So I think the solution would be to just use elixir = (pkgs.beam.packagesWith pkgs.beam.interpreters.erlangR21_nox).elixir_1_8; in my case.
Which would make this PR obsolete?

But I'm far away of an Nix expert, so just my thoughts.

@DeltaEvo
Copy link
Member Author

DeltaEvo commented Mar 4, 2019

Yeah I use this too, but adding erlang_nox will make hydra build beam packages with erlang_nox and produce pre-build packages right ? (I'm not sure about this 🤔 )

@cw789
Copy link
Contributor

cw789 commented Mar 4, 2019

I think your deliberation is right.
But it only then would be faire to add the nox version of all current Erlang versions as package,
which then is going quite far in my opinion, as the nox version is quite specialized and not that widely used.

So I think the better solution for us would be to use Cachix instead?

But I'm sure it's a pain to build yourself up front - as it's taking quite some minutes.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@DeltaEvo
Copy link
Member Author

DeltaEvo commented Jun 2, 2020

still important to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@tolbrino
Copy link
Contributor

tolbrino commented Jun 3, 2020

Yeah I use this too, but adding erlang_nox will make hydra build beam packages with erlang_nox and produce pre-build packages right ? (I'm not sure about this thinking )

In that case this PR should also make the other variants (e.g. _javac) and these variants for all available versions of Erlang/OTP available.

@DeltaEvo
Copy link
Member Author

DeltaEvo commented Jun 4, 2020

In that case this PR should also make the other variants (e.g. _javac) and these variants for all available versions of Erlang/OTP available.

I can add them, but I don't know much about these version, maybe if another user need them it will make a pull request ? the nox version is very handy for a server for example when you don't want that your erlang application pull all theses dependencies

@tolbrino
Copy link
Contributor

tolbrino commented Jun 5, 2020

There is not much to know about. Just like the _nox variant they simply disable certain features. So its a mere copy and paste for all of these. I think if anything it really should be done for all or none.

@tolbrino
Copy link
Contributor

tolbrino commented Sep 1, 2020

@DeltaEvo Are you planing to adapt the PR?

@DeltaEvo
Copy link
Member Author

DeltaEvo commented Sep 4, 2020

I don't have the time now, so I am not planing to adapt it :(

@happysalada
Copy link
Contributor

I think this is now in the main repo. Perhaps we can close this now?
Feel free to update if I'm wrong.

@happysalada
Copy link
Contributor

Since this is already on master, I am going to close this for now, feel free to re-open if I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants