Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redmine: 3.4.6 -> 3.4.8 #54933

Merged
merged 1 commit into from Jan 31, 2019
Merged

redmine: 3.4.6 -> 3.4.8 #54933

merged 1 commit into from Jan 31, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 30, 2019

Motivation for this change

Version bump.

Fairly minor changelog from 3.4.6 to 3.4.8: https://www.redmine.org/projects/redmine/wiki/Changelog_3_4

Note: I have tested this on 18.09 as well so this should be back ported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test redmine

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-january/2002/1

@Ekleog
Copy link
Member

Ekleog commented Jan 31, 2019

@garbas cc as a maintainer, I'm merging as it looks right, feel free to revert if I missed something

@Ekleog
Copy link
Member

Ekleog commented Jan 31, 2019

BTW, @aanderse , you could consider adding yourself as a maintainer, as you appear to have done all the recent work on it :)

@Ekleog Ekleog merged commit 0f3ecc6 into NixOS:master Jan 31, 2019
@aanderse
Copy link
Member Author

aanderse commented Jan 31, 2019

@Ekleog Thank you. Yeah I guess at this point that makes sense.

Please backport this to 18.09 as well as it does have some (minor) security fixes!

@Ekleog
Copy link
Member

Ekleog commented Jan 31, 2019

@aanderse I've been trying to run nix-build nixos/tests/redmine.nix locally and it fails (both before and after the change on both release-18.09 and master). Could you open a PR for the backport (done with git cherry-pick -x) so that ofborg could run against it?

@aanderse aanderse mentioned this pull request Feb 1, 2019
10 tasks
@aanderse aanderse deleted the redmine branch February 1, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants