Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tableaudocumentapi: init at 0.6 #54956

Merged
merged 1 commit into from Jan 31, 2019
Merged

pythonPackages.tableaudocumentapi: init at 0.6 #54956

merged 1 commit into from Jan 31, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Working with tableau and want to experiment with python package for dealing with tableau documents.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner January 30, 2019 18:54
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.tableaudocumentapi python3Packages.tableaudocumentapi

@costrouc costrouc force-pushed the costrouc-tableaudocumentapi-init branch from a3e45f9 to bd1a7df Compare January 30, 2019 23:18
@worldofpeace
Copy link
Contributor

I noticing that the repo is called document-api-python and on PyPi it's tableaudocumentapi.

Not sure what will be more discoverable but the hyphenated one is more readable.

@dotlambda
Copy link
Member

We usually go with the PyPI name.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.tableaudocumentapi python3.pkgs.tableaudocumentapi

@dotlambda dotlambda merged commit 518a7b0 into NixOS:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @worldofpeace @dotlambda @GrahamcOfBorg