Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua-5 setup-hook: quiet noisy 'cd -' printing path repeatedly #54961

Merged
merged 1 commit into from Jan 31, 2019
Merged

lua-5 setup-hook: quiet noisy 'cd -' printing path repeatedly #54961

merged 1 commit into from Jan 31, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 30, 2019

Motivation for this change

This may depend on what /bin/sh is used, didn't check,
but on my builder as well as with my normal shell
using cd - (helpfully, usually) prints the path name to stdout
which unfortunately can cause a fair amount of log spam
since this is executed for many store paths.

(although the path printed was /build repeatedly in what I saw)

Anyway this just quiets the print.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 31, 2019

Will send to staging instead.

@dtzWill dtzWill closed this Jan 31, 2019
@dtzWill dtzWill reopened this Jan 31, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Jan 31, 2019

Just kidding--the bits this fixes (lua setup-hook) isn't in staging yet! xD

@dtzWill
Copy link
Member Author

dtzWill commented Jan 31, 2019

cc #54460 where this was introduced :).

@teto
Copy link
Member

teto commented Jan 31, 2019

thanks for this. LGTM.

@dtzWill dtzWill merged commit e5a8918 into NixOS:master Jan 31, 2019
@dtzWill dtzWill deleted the update/lua-setuphook-shoosh-hush-please branch January 31, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @teto @GrahamcOfBorg