sage: python-openid: move django and twill to checkInputs #54949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A search through the source code (https://github.com/openid/python-openid/search?q=django and https://github.com/openid/python-openid/search?q=twill) reveals that they are only used in examples and tests.
|
No objections in principle. Did you run the sage tests? |
|
@GrahamcOfBorg build sage.quicktest |
I did not. I can hardly imagine this having any impact on sage. |
|
It might indirectly if I forgot to add those dependencies somewhere up the dependency tree and it just happened to work because they were propagated. The quicktests passing is good enough for me though. Thanks for caring about the closure size :) |
timokau
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A search through the source code
(https://github.com/openid/python-openid/search?q=django and
https://github.com/openid/python-openid/search?q=twill) reveals
that they are only used in examples and tests.
Motivation for this change
reduce closure size
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)