Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverlessrepo: init at 0.1.6 #53095

Closed
wants to merge 3 commits into from
Closed

serverlessrepo: init at 0.1.6 #53095

wants to merge 3 commits into from

Conversation

jnsaff
Copy link
Contributor

@jnsaff jnsaff commented Dec 30, 2018

Motivation for this change

Added Python pypi package serverlessrepo that is needed for the upgrade of aws-sam-cli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

inherit pname version;
sha256 = "384dc37394ffe1c8036f79a78b15bada4cb954a39f07bdf68f123c1a191fd0b2";
};
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are tests disabled?

license = licenses.asl20;
maintainers = with maintainers; [ jnsaff ];
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final newline

];

meta = with lib; {
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository.";
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository";

We don't do periods add the end of description.

@worldofpeace
Copy link
Contributor

We need to leverage the disabled parameter of buildPythonPackage to disable this for particular python interpreter versions. Based off of the condition here.

@worldofpeace
Copy link
Contributor

Closing in favor of #59072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants