New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serverlessrepo: init at 0.1.6 #53095
Conversation
inherit pname version; | ||
sha256 = "384dc37394ffe1c8036f79a78b15bada4cb954a39f07bdf68f123c1a191fd0b2"; | ||
}; | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are tests disabled?
license = licenses.asl20; | ||
maintainers = with maintainers; [ jnsaff ]; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing final newline
]; | ||
|
||
meta = with lib; { | ||
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository."; | |
description = "A Python library with convenience helpers for working with the AWS Serverless Application Repository"; |
We don't do periods add the end of description
.
We need to leverage the |
Closing in favor of #59072 |
Motivation for this change
Added Python pypi package serverlessrepo that is needed for the upgrade of aws-sam-cli.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)